Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #130 prevent cargo metadata warnings from breaking everything #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rinconjc
Copy link

@rinconjc rinconjc commented Apr 5, 2022

No description provided.

@nemethf
Copy link
Contributor

nemethf commented Apr 6, 2022

I don't think it's a good idea to completely ignore errors in stderr. That makes solving the problems impossible as the user does not notice them in the first place.

@rinconjc
Copy link
Author

Fair point. The error output will now be sent to the Messages buffer.

@nemethf
Copy link
Contributor

nemethf commented Apr 12, 2022

Since I commented the original version, I continue but feel free to ignore me.

  • I don't use cargo.el with tramp, but process-file works on remote files whereas call-process doesn't.
  • buffer-string is a bit simpler than (with-output-to-string (with-current-buffer standard-output ....
  • It is not the fault of this PR, but the output of cargo inserted into a buffer, which then converted into a string, which json-read-from-string inserts into a buffer. This is a bit inefficient.

By the way, what kind of warnings / situation inspired this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants